This repository has been archived by the owner on Dec 2, 2021. It is now read-only.
[MLMD Lineage] Remove LineageView and use version from kubeflow/frontend #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will update to kubeflow/frontend once changes are merged
The relevant classes are available in frontend/mlmd.
This is the last essential change, so this branch is ready for PR once frontend changes are merged and synced with outstanding PRs.
…tegrate-frontend-merge-latest
…data into integrate-frontend-pr
|
@avdaredevil I've updated to the mainline version of kubeflow/frontend so this PR is tested and ready for review. |
avdaredevil
approved these changes
Jan 24, 2020
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: avdaredevil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind feature
/area metadata
/area front-end
/assign @avdaredevil
This PR removes the version of LineageView that was developed in the metadata
repo in favor the shared version in kubeflow/frontend.
Changes
Validation:
Deployment: http://kubeflow-ui-07.endpoints.kwasinti-kubeflow-dev.cloud.goog
This change is