Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Initial commit for UI #108 #114

Merged
merged 1 commit into from
May 30, 2024

Conversation

ederign
Copy link
Member

@ederign ederign commented May 29, 2024

The initial commit for UI, as discussed at #108.

Description

In this commit:

How Has This Been Tested?

> make run
> curl -i localhost:4000/api/v1/healthcheck/
HTTP/1.1 200 OK
Access-Control-Allow-Origin: *
Content-Type: application/json
Date: Wed, 29 May 2024 14:41:13 GMT
Content-Length: 70

{
	"status": "available",
	"system_info": {
		"version": "1.0.0"
	}
}
> make docker-build
>  docker run -p 4000:4000 -e PORT=4000 model-registry-bff
> curl -i localhost:4000/api/v1/healthcheck/
HTTP/1.1 200 OK
Access-Control-Allow-Origin: *
Content-Type: application/json
Date: Wed, 29 May 2024 14:41:13 GMT
Content-Length: 70

{
	"status": "available",
	"system_info": {
		"version": "1.0.0"
	}
}

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

In this commit:

- basic Dockerfile
- basic Makefile
- Scaffold of App and first sample endpoint (http://localhost:4000/api/v1/healthcheck/)
- REST API basic infrastructure and error handling

Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
@ederign ederign force-pushed the model-registry-ui-boostrap branch from 9727051 to cafc660 Compare May 29, 2024 15:49
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @ederign in the context of #108 I have just one question since you already have some form of testing in the makefile, do you want to "wire" a GitHub Action as part of this PR, or do you want to follow-up for that in another PR ?

@ederign
Copy link
Member Author

ederign commented May 30, 2024

@tarilabs thank you so much for the review! I'll send it on a FUP PR as soon as possible.

@tarilabs
Copy link
Member

@tarilabs thank you so much for the review! I'll send it on a FUP PR as soon as possible.

got it, works for me

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 8d77c13 into kubeflow:main May 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants