Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ederign in OWNERS in clients/ui/bff/OWNERS #131

Merged

Conversation

tarilabs
Copy link
Member

follow-up to:

make Eder approver in subdir of the BFF work.

Note: Eder is already a KF member.

Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
@tarilabs
Copy link
Member Author

/assign @rareddy

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rimolive
Copy link
Member

/lgtm

Copy link
Contributor

@rareddy rareddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rareddy, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 350a6a3 into kubeflow:main Jun 17, 2024
12 checks passed
mzhl1111 pushed a commit to mzhl1111/model-registry that referenced this pull request Jul 1, 2024
Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
Signed-off-by: muzhouliu <sllzhlv77@gmail.com>
dhirajsb pushed a commit to dhirajsb/model-registry-kfp that referenced this pull request Jul 10, 2024
Ref: kubeflow#131
Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants