Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl-delivery's Dockerfile fails in distroless #254

Closed
terrytangyuan opened this issue May 13, 2020 · 5 comments · Fixed by #256
Closed

kubectl-delivery's Dockerfile fails in distroless #254

terrytangyuan opened this issue May 13, 2020 · 5 comments · Fixed by #256

Comments

@terrytangyuan
Copy link
Member

terrytangyuan commented May 13, 2020

Thanks @audriusrudalevicius for bringing this up in #196 (comment).

Currently cmd/kubectl-delivery/Dockerfile has ENTRYPOINT ["/bin/sh", "-c"] which fails in distroless image:

docker run -it --rm --entrypoint=/bin/sh gcr.io/distroless/base-debian10
docker: Error response from daemon: OCI runtime create failed: container_linux.go:346: starting container process caused "exec: \"/bin/sh\": stat /bin/sh: no such file or directory": unknown.

Also cc @carmark

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/bug 0.91

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@rongou
Copy link
Member

rongou commented May 13, 2020

@terrytangyuan
Copy link
Member Author

@rongou Would it be a problem of running builds on your fork rongou/mpi-operator? Building it locally seems successful.

@terrytangyuan
Copy link
Member Author

The dockerfile here seems outdated: https://hub.docker.com/r/mpioperator/kubectl-delivery/dockerfile

@rongou
Copy link
Member

rongou commented May 13, 2020

Ok I fixed the build. It's a configuration issue on dockerhub.

As for the failure, perhaps we shouldn't use distroless in this case as the main thing the container is doing is to copy a file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants