Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup info for Python SDK #463

Closed

Conversation

shaowei-su
Copy link
Contributor

This change enables easy command line pip installation for the Python SDK v1 & v2beta1, e.g

pip install git+https://github.com/kubeflow/mpi-operator.git#subdirectory=sdk/python/v2beta1

Ideally the package should be published to Pypi but skip it for now since mpi-operator v2 will eventually merged into training-operator and Python SDK is already maintained in the other repo (kubeflow/training-operator#1380).

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rongou after the PR has been reviewed.
You can assign the PR to them by writing /assign @rongou in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alculquicondor
Copy link
Collaborator

we won't necessarily move the v2 operator to training

kubeflow/community#557 (open discussion)

Any python experts are able to review this?

@shaowei-su
Copy link
Contributor Author

Closing for now since the the SDK seems lack basic client interface like TFJobClient (https://github.com/kubeflow/training-operator/blob/master/sdk/python/kubeflow/training/api/tf_job_client.py).

@shaowei-su shaowei-su closed this Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants