Use local copy of RunPolicy by MPI-operator #513
Conversation
Steps performed: - copy the `RunPolicy` from common to `types.go` - fix compilation errors by using the local RunPolicy definition - run `make generate` - run `make all` - regenerate openapi_generated.go by `./hack/python-sdk/gen-sdk.sh` (with commented out rollback)
|
/assign @tenzen-y |
|
@alculquicondor please review. |
pkg/apis/kubeflow/v2beta1/types.go
Outdated
| type RunPolicy struct { | ||
| // CleanPodPolicy defines the policy to kill pods after the job completes. | ||
| // Default to Running. | ||
| CleanPodPolicy *common.CleanPodPolicy `json:"cleanPodPolicy,omitempty"` |
There was a problem hiding this comment.
Can you copy the CleanPodPolicy from kubeflow/common to this repo?
There was a problem hiding this comment.
Sure, it wasn't clear to me from the so far discussions so did it with minimal changes required to place the suspend field, but let me update.
There was a problem hiding this comment.
It might be better to copy all types, and members to this repo since moving only part of those might make double management.
cc: @alculquicondor
There was a problem hiding this comment.
Copied, PTAL at the last commit.
pkg/apis/kubeflow/v2beta1/types.go
Outdated
|
|
||
| // SchedulingPolicy defines the policy related to scheduling, e.g. gang-scheduling | ||
| // +optional | ||
| SchedulingPolicy *common.SchedulingPolicy `json:"schedulingPolicy,omitempty"` |
There was a problem hiding this comment.
Can you copy the SchedulingPolicy from kubeflow/common to this repo?
There was a problem hiding this comment.
As above, about to copy too.
mimowo
force-pushed
the
copy-runpolicy
branch
from
ce37edd
to
44db325
Compare
|
/assign @alculquicondor |
|
@terrytangyuan Can you approve CI? |
|
/ok-to-test EDIT: no, it didn't work |
Yes, we can not start CI by prow command. Repository admins need to approve CI manually. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
|
@alculquicondor please complete the review and cancel the hold if it looks good so I can rebase the other PR. |
|
/hold cancel |
|
/assign @terrytangyuan |
This is a preparatory commit to add
suspendfield toRunPolicyin #511Steps performed:
RunPolicyfrom common totypes.gomake generatemake all./hack/python-sdk/gen-sdk.sh(with commented out rollback)