Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golang and controller-gen #636

Closed
wants to merge 1 commit into from

Conversation

alculquicondor
Copy link
Collaborator

To prepare for release.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from alculquicondor. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member

Signed-off-by: Aldo Culquicondor <acondor@google.com>
@alculquicondor
Copy link
Collaborator Author

I missed make generate.

Fixed.

@tenzen-y
Copy link
Member

I missed make generate.

Fixed.

@alculquicondor I guess that you missed make crd.

@tenzen-y
Copy link
Member

I missed make generate.
Fixed.

@alculquicondor I guess that you missed make crd.

NVM. There are any other reasons...

@alculquicondor
Copy link
Collaborator Author

Yeah, I don't know what I missed

@tenzen-y
Copy link
Member

tenzen-y commented Apr 17, 2024

Yeah, I don't know what I missed

I found that your PR dropped some fields from swagger.json.

master branch:

"runLauncherAsWorker": {
"description": "RunLauncherAsWorker indicates whether to run worker process in launcher Defaults to false.",
"type": "boolean"

this PR: https://github.com/alculquicondor/mpi-operator/blob/973702775818aac7452963f594b43da5e732089a/pkg/apis/kubeflow/v2beta1/swagger.json#L159-L161

@alculquicondor Did make generate succeed in your local?

@alculquicondor
Copy link
Collaborator Author

Something is hexed in my local repo

/close

@google-oss-prow google-oss-prow bot closed this Apr 17, 2024
Copy link

@alculquicondor: Closed this PR.

In response to this:

Something is hexed in my local repo

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants