-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade golang and controller-gen #636
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@alculquicondor Could you follow this DCO step? |
Signed-off-by: Aldo Culquicondor <acondor@google.com>
I missed Fixed. |
@alculquicondor I guess that you missed |
NVM. There are any other reasons... |
Yeah, I don't know what I missed |
I found that your PR dropped some fields from swagger.json.
mpi-operator/pkg/apis/kubeflow/v2beta1/swagger.json Lines 159 to 161 in 1b33fec
this PR: https://github.com/alculquicondor/mpi-operator/blob/973702775818aac7452963f594b43da5e732089a/pkg/apis/kubeflow/v2beta1/swagger.json#L159-L161 @alculquicondor Did |
Something is hexed in my local repo /close |
@alculquicondor: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
To prepare for release.