Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

Upgrade Golang version to 1.13.8 and Kubernetes version to 1.15.9 #53

Merged
merged 7 commits into from
Mar 9, 2020
Merged

Upgrade Golang version to 1.13.8 and Kubernetes version to 1.15.9 #53

merged 7 commits into from
Mar 9, 2020

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented Feb 28, 2020 •
edited
Loading

  1. Upgrade Dockerfile base image goland verison and travis CI golang version to 1.13.8
  2. Migrate from Dep to go module
  3. Upgrade Kubernetes dependencies to 1.15.9 and regenerate client and api codes
  4. Upgrade code-gen scripts to use mod code-generator in GOPATH/pkg/mod and deprecate vendor folder

This change is Reviewable

@Jeffwan Jeffwan mentioned this pull request Feb 28, 2020
Closed
@TravisBuddy
Copy link

Travis tests have failed

Hey @Jeffwan,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 5cd19220-5a60-11ea-af10-7fd2d08fe4df

@Jeffwan Jeffwan changed the title Upgrade golang version to v1.13.8 Migrate from Dep to go modules Feb 28, 2020
@gaocegege
Copy link
Member

Tests are failed, can you please fix it?

Thanks

@TravisBuddy
Copy link

Hey @Jeffwan,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 7ff7b510-5b21-11ea-b66e-89572c858fbd

@TravisBuddy
Copy link

Travis tests have failed

Hey @Jeffwan,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: f2e8fdc0-5b23-11ea-b66e-89572c858fbd

@Jeffwan Jeffwan mentioned this pull request Feb 29, 2020
Merged
@Jeffwan
Copy link
Member Author

Jeffwan commented Mar 1, 2020

@gaocegege go linter problem, current library has been deprecated. I file a separate PR #56 to address this issue and copyright header to fix CI. This PR will be updated later.

@TravisBuddy
Copy link

Travis tests have failed

Hey @Jeffwan,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: f0503240-5d17-11ea-9390-21607e5de829

@Jeffwan Jeffwan changed the title Migrate from Dep to go modules Upgrade Golang version to 1.13.8 and Kubernetes version to 1.15.9 Mar 3, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @Jeffwan,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: b4f03c70-5d19-11ea-9390-21607e5de829

@TravisBuddy
Copy link

Travis tests have failed

Hey @Jeffwan,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 1da4f260-5d1f-11ea-9390-21607e5de829

@Jeffwan
Copy link
Member Author

Jeffwan commented Mar 3, 2020

/cc @wackxu @gaocegege

@k8s-ci-robot k8s-ci-robot requested a review from wackxu March 3, 2020 08:55
@Jeffwan
Copy link
Member Author

Jeffwan commented Mar 3, 2020

I have a follow up PR to delete vendor folder. I want to make this PR clear and easy to review.

@Jeffwan
Copy link
Member Author

Jeffwan commented Mar 9, 2020

/cc @gaocegege @wackxu kindly ping. :D

@wackxu
Copy link
Contributor

wackxu commented Mar 9, 2020

Thanks for your contribution.
/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wackxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f60bdce into kubeflow:master Mar 9, 2020
@Jeffwan Jeffwan deleted the upgrade_golang_version branch March 9, 2020 07:07
Jeffwan added a commit to Jeffwan/mxnet-operator that referenced this pull request Mar 9, 2020
@Jeffwan
Remove vendor directory
06d89d6 
`vendor` was from Godeps and has all build dependencies.
`go build` ignore vendor directory by default and as we migrate to use go modules, there’s no need to keep `vendor` any more. This is a follow up PR of kubeflow#53
./hack/update-codegen.sh has been upgrade to use code-generator under $GOPATH/pkg/mod

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
@Jeffwan Jeffwan mentioned this pull request Mar 9, 2020
Merged
k8s-ci-robot pushed a commit that referenced this pull request Mar 10, 2020
@Jeffwan
Remove vendor directory (#57)
ee26860 
`vendor` was from Godeps and has all build dependencies.
`go build` ignore vendor directory by default and as we migrate to use go modules, there’s no need to keep `vendor` any more. This is a follow up PR of #53
./hack/update-codegen.sh has been upgrade to use code-generator under $GOPATH/pkg/mod

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gaocegege gaocegege Awaiting requested review from gaocegege

@KingOnTheStar KingOnTheStar Awaiting requested review from KingOnTheStar

@wackxu wackxu Awaiting requested review from wackxu

Assignees

@wackxu wackxu

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Jeffwan @TravisBuddy @gaocegege @wackxu @k8s-ci-robot