Reduce ttl of persisted final workflow to 1 day (#4005)

* reduce ttl of pesisted final workflow to 1 day * add comment * enable pagination when expanding experiment in both the home page and the archive page * Revert "enable pagination when expanding experiment in both the home page and the archive page" This reverts commit 5b67273. * Address comments
kubeflow · Sep 11, 2020 · 135715d · 135715d
1 parent 9c4e864
commit 135715d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/backend/Dockerfile.persistenceagent b/backend/Dockerfile.persistenceagent
@@ -17,7 +17,7 @@ COPY --from=builder /go/src/github.com/kubeflow/pipelines/third_party/license.tx
 
 ENV NAMESPACE ""
 
-# Set Workflow TTL to 7 days
-ENV TTL_SECONDS_AFTER_WORKFLOW_FINISH 604800
+# Set Workflow TTL to 1 day. The way to use a different value for a particular Kubeflow Pipelines deployment is demonstrated in manifests/kustomize/base/pipeline/ml-pipeline-persistenceagent-deployment.yaml
+ENV TTL_SECONDS_AFTER_WORKFLOW_FINISH 86400
 
 CMD persistence_agent --logtostderr=true --namespace=${NAMESPACE} --ttlSecondsAfterWorkflowFinish=${TTL_SECONDS_AFTER_WORKFLOW_FINISH}
diff --git a/manifests/gcp_marketplace/chart/kubeflow-pipelines/templates/pipeline.yaml b/manifests/gcp_marketplace/chart/kubeflow-pipelines/templates/pipeline.yaml
@@ -514,6 +514,8 @@ spec:
         - env:
             - name: NAMESPACE
               value: {{ .Release.Namespace }}
+            - name: TTL_SECONDS_AFTER_WORKFLOW_FINISH
+              value: "86400"
           image: {{ .Values.images.persistenceagent }}
           imagePullPolicy: IfNotPresent
           name: ml-pipeline-persistenceagent

diff --git a/manifests/kustomize/base/pipeline/ml-pipeline-persistenceagent-deployment.yaml b/manifests/kustomize/base/pipeline/ml-pipeline-persistenceagent-deployment.yaml
@@ -19,6 +19,8 @@ spec:
             valueFrom:
               fieldRef:
                 fieldPath: metadata.namespace
+          - name: TTL_SECONDS_AFTER_WORKFLOW_FINISH
+            value: "86400"
         image: gcr.io/ml-pipeline/persistenceagent:dummy
         imagePullPolicy: IfNotPresent
         name: ml-pipeline-persistenceagent