remove cleanup param in local init (#10293)

sdk/python/kfp/local/config.py

@@ -32,7 +32,6 @@ def __new__(
         cls,
         runner: SubprocessRunner,
         pipeline_root: str,
-        cleanup: bool,
         raise_on_error: bool,
     ) -> 'LocalExecutionConfig':
         # singleton pattern
@@ -43,20 +42,17 @@ def __init__(
         self,
         runner: SubprocessRunner,
         pipeline_root: str,
-        cleanup: bool,
         raise_on_error: bool,
     ) -> None:
         self.runner = runner
         self.pipeline_root = pipeline_root
-        self.cleanup = cleanup
         self.raise_on_error = raise_on_error
 
 
 def init(
     # more runner types will eventually be supported
     runner: SubprocessRunner,
     pipeline_root: str = './local_outputs',
-    cleanup: bool = False,
     raise_on_error: bool = True,
 ) -> None:
     """Initializes a local execution session.
@@ -66,13 +62,11 @@ def init(
     Args:
         runner: The runner to use. Currently only SubprocessRunner is supported.
         pipeline_root: Destination for task outputs.
-        cleanup: Whether to ensure outputs are cleaned up after execution. If True, the task will be run in a temporary directory, rather than pipeline_root.
         raise_on_error: If True, raises an exception when a local task execution fails. If Falls, fails gracefully and does not terminal the current program.
     """
     # updates a global config
     LocalExecutionConfig(
         runner=runner,
         pipeline_root=pipeline_root,
-        cleanup=cleanup,
         raise_on_error=raise_on_error,
     )

sdk/python/kfp/local/config_test.py

@@ -28,29 +28,25 @@ def test_local_runner_config_init(self):
         config.LocalExecutionConfig(
             pipeline_root='my/local/root',
             runner=local.SubprocessRunner(use_venv=True),
-            cleanup=True,
             raise_on_error=True,
         )
 
         instance = config.LocalExecutionConfig.instance
 
         self.assertEqual(instance.pipeline_root, 'my/local/root')
         self.assertEqual(instance.runner, local.SubprocessRunner(use_venv=True))
-        self.assertIs(instance.cleanup, True)
         self.assertIs(instance.raise_on_error, True)
 
     def test_local_runner_config_is_singleton(self):
         """Test instance attributes with multiple constructor calls."""
         config.LocalExecutionConfig(
             pipeline_root='my/local/root',
             runner=local.SubprocessRunner(),
-            cleanup=True,
             raise_on_error=True,
         )
         config.LocalExecutionConfig(
             pipeline_root='other/local/root',
             runner=local.SubprocessRunner(use_venv=False),
-            cleanup=False,
             raise_on_error=False,
         )
 
@@ -59,7 +55,6 @@ def test_local_runner_config_is_singleton(self):
         self.assertEqual(instance.pipeline_root, 'other/local/root')
         self.assertEqual(instance.runner,
                          local.SubprocessRunner(use_venv=False))
-        self.assertFalse(instance.cleanup, False)
         self.assertFalse(instance.raise_on_error, False)
 
 
@@ -73,26 +68,22 @@ def test_init_more_than_once(self):
         local.init(
             pipeline_root='my/local/root',
             runner=local.SubprocessRunner(use_venv=True),
-            cleanup=True,
         )
 
         instance = config.LocalExecutionConfig.instance
 
         self.assertEqual(instance.pipeline_root, 'my/local/root')
         self.assertEqual(instance.runner, local.SubprocessRunner(use_venv=True))
-        self.assertTrue(instance.cleanup, True)
 
     def test_init_more_than_once(self):
         """Test config instance attributes with multiple init() calls."""
         local.init(
             pipeline_root='my/local/root',
             runner=local.SubprocessRunner(),
-            cleanup=True,
         )
         local.init(
             pipeline_root='other/local/root',
             runner=local.SubprocessRunner(use_venv=False),
-            cleanup=False,
             raise_on_error=False,
         )
 
@@ -101,7 +92,6 @@ def test_init_more_than_once(self):
         self.assertEqual(instance.pipeline_root, 'other/local/root')
         self.assertEqual(instance.runner,
                          local.SubprocessRunner(use_venv=False))
-        self.assertFalse(instance.cleanup, False)
         self.assertFalse(instance.raise_on_error, False)