Skip to content

Commit

Permalink
Tests - Fixed the argo submit failure not failing the script
Browse files Browse the repository at this point in the history
Removed pipe from argo submit.
Only the last pipe command affects the exit pipeline code unless `set -o pipefail` is used.
  • Loading branch information
Ark-kun committed Nov 20, 2018
1 parent f28a989 commit acbb730
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion test/presubmit-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,9 @@ ARGO_WORKFLOW=`argo submit $(dirname $0)/${WORKFLOW_FILE} \
-p api-image="${GCR_IMAGE_BASE_DIR}/api" \
-p frontend-image="${GCR_IMAGE_BASE_DIR}/frontend" \
-p scheduledworkflow-image="${GCR_IMAGE_BASE_DIR}/scheduledworkflow" \
-p persistenceagent-image="${GCR_IMAGE_BASE_DIR}/persistenceagent" | awk '/Name:/{print $NF}'`
-p persistenceagent-image="${GCR_IMAGE_BASE_DIR}/persistenceagent" \
-o name
`
echo argo workflow submitted successfully

echo "check status of argo workflow $ARGO_WORKFLOW...."
Expand Down

0 comments on commit acbb730

Please sign in to comment.