[UI] Allow choosing Kubernetes service account

kubeflow · Apr 29, 2020 · f9cdac5 · f9cdac5
1 parent bf35380
commit f9cdac5
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 3 deletions.
diff --git a/frontend/src/apis/job/api.ts b/frontend/src/apis/job/api.ts
@@ -138,11 +138,17 @@ export interface ApiJob {
    */
   pipeline_spec?: ApiPipelineSpec;
   /**
-   * Optional input field. Specify which resource this run belongs to.
+   * Optional input field. Specify which resource this job belongs to.
    * @type {Array<ApiResourceReference>}
    * @memberof ApiJob
    */
   resource_references?: Array<ApiResourceReference>;
+  /**
+   * Optional input field. Specify which Kubernetes service account this job uses.
+   * @type {string}
+   * @memberof ApiJob
+   */
+  service_account?: string;
   /**
    *
    * @type {string}

diff --git a/frontend/src/apis/run/api.ts b/frontend/src/apis/run/api.ts
@@ -346,6 +346,12 @@ export interface ApiRun {
    * @memberof ApiRun
    */
   resource_references?: Array<ApiResourceReference>;
+  /**
+   * Optional input field. Specify which Kubernetes service account this run uses.
+   * @type {string}
+   * @memberof ApiRun
+   */
+  service_account?: string;
   /**
    * Output. The time that the run created.
    * @type {Date}

diff --git a/frontend/src/index.tsx b/frontend/src/index.tsx
@@ -60,8 +60,8 @@ ReactDOM.render(
     <NamespaceContextProvider>{app}</NamespaceContextProvider>
   ) : (
     // Uncomment the following for namespace switch during development.
-    // <NamespaceContext.Provider value='your-namespace'>{app}</NamespaceContext.Provider>
-    <NamespaceContext.Provider value={undefined}>{app}</NamespaceContext.Provider>
+    <NamespaceContext.Provider value='kubeflow-gongyuan'>{app}</NamespaceContext.Provider>
+    // <NamespaceContext.Provider value={undefined}>{app}</NamespaceContext.Provider>
   ),
   document.getElementById('root'),
 );
diff --git a/frontend/src/pages/NewRun.tsx b/frontend/src/pages/NewRun.tsx
@@ -62,6 +62,7 @@ interface NewRunState {
   errorMessage: string;
   experiment?: ApiExperiment;
   experimentName: string;
+  serviceAccount: string;
   experimentSelectorOpen: boolean;
   isBeingStarted: boolean;
   isClone: boolean;
@@ -115,6 +116,7 @@ export class NewRun extends Page<{ namespace?: string }, NewRunState> {
     description: '',
     errorMessage: '',
     experimentName: '',
+    serviceAccount: '',
     experimentSelectorOpen: false,
     isBeingStarted: false,
     isClone: false,
@@ -175,6 +177,7 @@ export class NewRun extends Page<{ namespace?: string }, NewRunState> {
       description,
       errorMessage,
       experimentName,
+      serviceAccount,
       experimentSelectorOpen,
       isClone,
       isFirstRunInExperiment,
@@ -485,6 +488,14 @@ export class NewRun extends Page<{ namespace?: string }, NewRunState> {
             }}
           />
 
+          <div>This run will use the following Kubernetes service account.</div>
+          <Input
+            value={serviceAccount}
+            onChange={this.handleChange('serviceAccount')}
+            label='Service Account (Optional)'
+            variant='outlined'
+          />
+
           {/* One-off/Recurring Run Type */}
           <div className={commonCss.header}>Run Type</div>
           {isClone && <span>{isRecurringRun ? 'Recurring' : 'One-off'}</span>}
@@ -1025,6 +1036,7 @@ export class NewRun extends Page<{ namespace?: string }, NewRunState> {
           : undefined,
       },
       resource_references: references,
+      service_account: this.state.serviceAccount,
     };
     if (this.state.isRecurringRun) {
       newRun = Object.assign(newRun, {