Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel test fails at org_tensorflow/third_party/gpus/cuda_configure.bzl #1288

Closed
Ark-kun opened this issue May 7, 2019 · 8 comments
Closed

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented May 7, 2019

On a clean master checkout:

$ bazel test --action_env=PATH --define=grpc_no_ares=true //backend/...
Starting local Bazel server and connecting to it...
ERROR: /usr/local/google/home/avolkov/.cache/bazel/_bazel_avolkov/17d56a732ef8eb95c69f60d2038f8235/external/org_tensorflow/third_party/gpus/cuda_configure.bzl:115:1: load() statements must be called before any other statement. First non-load() statement appears at /usr/local/google/home/avolkov/.cache/bazel/_bazel_avolkov/17d56a732ef8eb95c69f60d2038f8235/external/org_tensorflow/third_party/gpus/cuda_configure.bzl:26:1. Use --incompatible_bzl_disallow_load_after_statement=false to temporarily disable this check.
ERROR: error loading package '': in /usr/local/google/home/avolkov/.cache/bazel/_bazel_avolkov/17d56a732ef8eb95c69f60d2038f8235/external/org_tensorflow/tensorflow/workspace.bzl: Label '@org_tensorflow//third_party:nccl/nccl_configure.bzl' crosses boundary of subpackage '@org_tensorflow//third_party/nccl' (perhaps you meant to put the colon here: '@org_tensorflow//third_party/nccl:nccl_configure.bzl'?)
ERROR: error loading package '': in /usr/local/google/home/avolkov/.cache/bazel/_bazel_avolkov/17d56a732ef8eb95c69f60d2038f8235/external/org_tensorflow/tensorflow/workspace.bzl: Label '@org_tensorflow//third_party:nccl/nccl_configure.bzl' crosses boundary of subpackage '@org_tensorflow//third_party/nccl' (perhaps you meant to put the colon here: '@org_tensorflow//third_party/nccl:nccl_configure.bzl'?)
INFO: Elapsed time: 7.180s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)
FAILED: Build did NOT complete successfully (0 packages loaded)

tensorflow/tensorboard#2181

P.S. Why are we building tensorflow as part of our backend?

@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 7, 2019

The problems are with Tensorflow bazel files.

Fixes are in master version (no release yet):
tensorflow/tensorflow@494d2cc
tensorflow/tensorflow@2243bd6

@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 29, 2019

Workaround: downgrade bazel binary to .23 version.

@IronPan
Copy link
Member

IronPan commented Jun 25, 2019

Update - It's now using bazel 0.24

FROM l.gcr.io/google/bazel:0.24.0 as builder

@Ark-kun Ark-kun removed their assignment Aug 6, 2019
@yanniszark
Copy link
Contributor

@IronPan @Ark-kun bumping this issue since tensorflow 1.14 is out now and seems to fix this issue.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 19, 2019

With TF 1.14.0 I have the following build error on latest Bazel:

$ /usr/bin/bazel run //:gazelle
INFO: Writing tracer profile to '/usr/local/google/home/avolkov/.cache/bazel/_bazel_avolkov/31e08d5c4be525ad16464e998010eee7/command.profile.gz'
INFO: SHA256 (https://github.com/tensorflow/tensorflow/archive/v1.14.0.tar.gz) = aa2a6a1daafa3af66807cfe0bc77bfe1144a9a53df9a96bab52e3e575b3047ed
DEBUG: Rule 'org_tensorflow' indicated that a canonical reproducible form can be obtained by modifying arguments sha256 = "aa2a6a1daafa3af66807cfe0bc77bfe1144a9a53df9a96bab52e3e575b3047ed"
DEBUG: Call stack for the definition of repository 'org_tensorflow' which is a http_archive (rule definition at /usr/local/google/home/avolkov/.cache/bazel/_bazel_avolkov/31e08d5c4be525ad16464e998010eee7/external/bazel_tools/tools/build_defs/repo/http.b
zl:262:16):
 - /usr/local/google/home/avolkov/go/src/github.com/kubeflow/pipelines/WORKSPACE:39:1
ERROR: /usr/local/google/home/avolkov/.cache/bazel/_bazel_avolkov/31e08d5c4be525ad16464e998010eee7/external/org_tensorflow/tensorflow/workspace.bzl:18:1: file '@io_bazel_rules_closure//closure:defs.bzl' does not contain symbol 'filegroup_external'
ERROR: error loading package '': Extension file 'tensorflow/workspace.bzl' has errors

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 19, 2019

@neuromage Does the backend still depend on tensorflow?

@stale
Copy link

stale bot commented Jun 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jun 25, 2020
@stale
Copy link

stale bot commented Jul 2, 2020

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@stale stale bot closed this as completed Jul 2, 2020
@Ark-kun Ark-kun removed the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Sep 22, 2020
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants