Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't read full text in "Choose a pipeline" dialog #154

Closed
sijieamoy opened this issue Nov 8, 2018 · 10 comments · Fixed by #2494
Closed

Can't read full text in "Choose a pipeline" dialog #154

sijieamoy opened this issue Nov 8, 2018 · 10 comments · Fixed by #2494
Assignees
Labels
area/frontend help wanted The community is welcome to contribute. kind/bug priority/p1

Comments

@sijieamoy
Copy link

The parts that are visible in the Pipeline name and the Description columns are too short to decide which one to choose.
image

Maybe allow text wrapping with a max row height, and/or narrowing the timestamp column?
image

@yebrahim
Copy link
Contributor

yebrahim commented Nov 9, 2018

I personally prefer giving description more horizontal space, but I'm ok with allowing it to wrap around, although maybe 5 lines is a bit too heigh.

@yebrahim
Copy link
Contributor

@sijieamoy are you up for sending a PR for this?

@cwbeitel
Copy link

Second this issue.

@vicaire
Copy link
Contributor

vicaire commented Mar 26, 2019

Riley, is this one still an issue?

@rileyjbauer
Copy link
Contributor

Yes, this is still an issue

@rileyjbauer
Copy link
Contributor

@yebrahim what would you think about expanding the dialog horizontally a bit, but also adding a tooltip to the description cell?

@yebrahim
Copy link
Contributor

I think the right solution would involve a more dedicated experience, perhaps a catalog-like UI, for picking the right pipeline. As a fix for this issue, I think what @sijieamoy suggested is good enough, perhaps with a limit on the number of characters or height of the description preview.

@Bobgy Bobgy assigned Bobgy and unassigned rileyjbauer Oct 23, 2019
@Bobgy Bobgy added the help wanted The community is welcome to contribute. label Oct 23, 2019
@Bobgy
Copy link
Contributor

Bobgy commented Oct 23, 2019

I agree with wrapping description and narrowing timestamp, but we need to rethink about the paging behavior here too.

Maybe an gradual loading list as you scroll with wrapped description sounds like a good idea?

That takes some thorough design. At the meantime, as a fast fix, we can add a title attribute to description that shows full text pop-up on hover. What do you think about this?

@Bobgy
Copy link
Contributor

Bobgy commented Oct 25, 2019

Bump priority, because it will be worse in latest release:
Screen Shot 2019-10-25 at 9 52 08 AM

@Bobgy
Copy link
Contributor

Bobgy commented Oct 25, 2019

I made the dialog bigger first, I think that's enough for usual use case.
download (20)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend help wanted The community is welcome to contribute. kind/bug priority/p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants