-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clone from Run UI is terrible with JSON #2714
Comments
/area frontend |
Thanks! That sounds useful. I don't currently have time to work on this, anyone is welcome to contribute before I've got some bandwidth on this. |
Providing a button nearby that can change the text box to a multiline editor might be helpful. |
/priority p1 |
I would like to provide PR for this issue |
Thanks @fenglixa! You are welcome, but @drewbutlerbb4 has already made a PR. Let's avoid duplicate efforts. |
Yes, I found that already PR on this issue. Thanks @Bobgy @drewbutlerbb4 |
Removing the label, as it is obviously more complex than I thought. Thanks @drewbutlerbb4! Well thought through the use case. |
What happened:
Try to clone a run (via the clone run button) that uses JSON strings as run parameters.
While the JSON run parameters show decently enough on the run's config tab (see #2713 for issues about that),
cloning such a run shows minified JSON in the form. This is a terrible user experience for someone that just wants to iterate on hyperparameters for example.
What did you expect to happen:
A similar but editable snippet of JSON to be rendered instead of the minified line of text
What steps did you take:
Cloned a run that contains JSON like run parameters
Attached is a screenshot of the config page that renders JSON snippet:
and its direct equivalent when clicking on the clone run button:
The text was updated successfully, but these errors were encountered: