New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1 visualizations backward compatible in v2 compatible #5666
Comments
/assign @chensun |
I'd really like to see |
@Ark-kun the goal of this issue is to ease migration, when switching to v2-compatible pipelines, people can gradually move to type-based visualization with their existing pipelines. |
Moving to P1, because Chen does not have time to work on this before 6.4. We may work on the doc update first. |
…art of kubeflow#5666 (kubeflow#5832) * fix(sdk/compiler): v2 compat - fix mlpipeline-ui-metadata artifact * fix * add test case * address feedback, fix the bug in less hacky way
I have a few questions regarding writing sample pipelines and visualizing on UI: Sample PipelineIs there a sample pipeline which writes v1 mlpipeline-ui-metadata Artifact naming in python codeI tried to write the following component, but was not successful because python doesn't accept
I slightly changed the name to something else so I can preview the content in output artifact. Here is the content:
Source data sample for each visualizationThere are 6 different V1 outputs in https://www.kubeflow.org/docs/components/pipelines/sdk/output-viewer/#available-output-viewers, but I am looking for some sample data in a csv file or other format to be able to store in the visualization content. See below:
Read file permission and test casesIf we use a gcs path or minio path for storing the visualization data, what kind of permission do we need to give to KFP for accessing those files? Can they be added to the KFP repo? |
It's blocked by #5831. Ideally, all v1 samples should be able to run in v2 compatible mode.
Traditionally, KFP v1 sanitizes artifact names by turning all letters to lower case and all non letter chars to I think it's worth considering letting UI do the name sanitization for this specific artifact name if sdk v2 doesn't.
Not quite following, do you want samples for these cases?
KFP UI server fetches these artifacts, by default we already mount MinIO secrets on it. On GCP it gets cluster default service account permission. So you don't need to worry about permission, users are responsible for setting them in their cluster. |
Thank you @Bobgy for the answers!
So we cannot create python component with Or is there any other approach to create a pipeline while waiting for the blocking issue to resolve?
I would like to learn more about As a result, how does user define a component in v1 fashion but is runnable on v2 compatible mode? More specifically, how does user define a
Sorry for the confusion, yes I want to have a simplified sample for these output viewer case. For example: we can define a simple confusion matrix with only 2 labels, but with actual Is there any existing sample which can achieve this goal? I found this file https://github.com/kubeflow/pipelines/blob/master/components/local/confusion_matrix/component.yaml but was stuck at trying to create a
Sounds good, thank you for clarifying ! |
@zijianjoy https://www.github.com/kubeflow/pipelines/tree/f3e368410e2d29cf880cd6debc95572b636dd208/samples%2Fcore%2Fvisualization%2Ftensorboard_minio.py You can adapt this example first. The only way to write a visualization component for both v1 and v2 compatible right now is to write a yaml component with artifact name Another way for lightweight components is to return the json metadata as NamedTuple. See example https://github.com/kubeflow/pipelines/blob/master/samples/core/lightweight_component/lightweight_component.ipynb. No, I don't have any existing examples. Existing examples are all around a specific use-case. It would be very helpful building an example with all the available visualizations simply hard coded. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
support v1 visualizations:
https://www.kubeflow.org/docs/components/pipelines/sdk/output-viewer/
Changes needed:
The text was updated successfully, but these errors were encountered: