test(components): Reduce sagemaker component test flakiness #10225
Conversation
| @@ -280,6 +280,8 @@ function cleanup_kfp() { | |||
| # If this fails, deleting the nodegroup later will clean it up anyway | |||
| kill -9 $MINIO_PID || true | |||
| fi | |||
| kubectl delete -k "github.com/kubeflow/pipelines/manifests/kustomize/env/cert-manager/dev?ref=$KFP_VERSION&timeout=90s" | |||
There was a problem hiding this comment.
How long does this line take? Do we need to add wait time?
There was a problem hiding this comment.
About 2 minutes at the maximum since this is a lightweight distribution, wait time is unnecessary here. My concern was more about the installation, it may take longer because of needing to create the persistent volume, which depends on EBS. I think the best solution might just be to uninstall on test failure.
There was a problem hiding this comment.
Addressed in new revision, uninstallation only occurs on failure which mitigates the risk of a long uninstallation/installation.
ananth102
force-pushed
the
simplekfpfixes
branch
2 times, most recently
from
3cda2a6
to
2fd35b8
Compare
Signed-off-by: ananth102 <abashyam@amazon.com>
ananth102
force-pushed
the
simplekfpfixes
branch
from
a012f78
to
4f380df
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rd-pong, ryansteakley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…#10225) Signed-off-by: ananth102 <abashyam@amazon.com>
…#10225) Signed-off-by: ananth102 <abashyam@amazon.com>
…#10225) Signed-off-by: ananth102 <abashyam@amazon.com>
Description of your changes:
Checklist: