New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(backend): get pipeline by name is broken due to version typo, Fixes #9940 #10268
Conversation
function getPipelineByName have a version typo: V1beta1 -> v1beta1
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi @cybernagle. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest-required |
@cybernagle: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@cybernagle Can you please sign the CLA following the the instruction, also split the SDK change out as a separate PR? Thanks! |
/test kubeflow-pipeline-upgrade-test |
No problem, already sign the CLA & rolled back of SDK changes. and will raise another PR to do such feature. |
@chensun please feel free to comment if you need me to change anything else. thanks a lot. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks, @cybernagle !
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeflow#9940 (kubeflow#10268) function getPipelineByName have a version typo: V1beta1 -> v1beta1 Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
kubeflow#9940 (kubeflow#10268) function getPipelineByName have a version typo: V1beta1 -> v1beta1
kubeflow#9940 (kubeflow#10268) function getPipelineByName have a version typo: V1beta1 -> v1beta1
kubeflow#9940 (kubeflow#10268) function getPipelineByName have a version typo: V1beta1 -> v1beta1
function getPipelineByName have a version typo:
V2beta1 -> v2beta1
thanks for @Jimmyshao 's help to find out this issue.
Description of your changes:
Checklist: