Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): get pipeline by name is broken due to version typo, Fixes #9940 #10268

Merged
merged 2 commits into from Feb 9, 2024

Conversation

cybernagle
Copy link
Contributor

@cybernagle cybernagle commented Nov 28, 2023

function getPipelineByName have a version typo:
V2beta1 -> v2beta1

thanks for @Jimmyshao 's help to find out this issue.
Description of your changes:

Checklist:

function getPipelineByName have a version typo:
V1beta1 -> v1beta1
Copy link

google-cla bot commented Nov 28, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

Hi @cybernagle. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cybernagle cybernagle changed the title fix: get pipeline by name is broken due to version typo, not issues yet. fix(backend): get pipeline by name is broken due to version typo, not issues yet. Nov 28, 2023
@cybernagle cybernagle changed the title fix(backend): get pipeline by name is broken due to version typo, not issues yet. fix(backend): get pipeline by name is broken due to version typo, not gh issues yet. Nov 28, 2023
@cybernagle cybernagle changed the title fix(backend): get pipeline by name is broken due to version typo, not gh issues yet. fix(backend): get pipeline by name is broken due to version typo, #9940 Nov 28, 2023
@cybernagle cybernagle changed the title fix(backend): get pipeline by name is broken due to version typo, #9940 fix(backend): get pipeline by name is broken due to version typo, Fixes #9940 Nov 28, 2023
@chensun
Copy link
Member

chensun commented Dec 1, 2023

/ok-to-test

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@chensun
Copy link
Member

chensun commented Dec 1, 2023

/retest-required

Copy link

google-oss-prow bot commented Dec 1, 2023

@cybernagle: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-sdk-yapf 8bdae7f link true /test kubeflow-pipelines-sdk-yapf

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chensun
Copy link
Member

chensun commented Dec 1, 2023

@cybernagle Can you please sign the CLA following the the instruction, also split the SDK change out as a separate PR? Thanks!

@chensun
Copy link
Member

chensun commented Dec 1, 2023

/test kubeflow-pipeline-upgrade-test

@cybernagle
Copy link
Contributor Author

cybernagle commented Dec 2, 2023

@cybernagle Can you please sign the CLA following the the instruction, also split the SDK change out as a separate PR? Thanks!

No problem, already sign the CLA & rolled back of SDK changes. and will raise another PR to do such feature.

@cybernagle
Copy link
Contributor Author

@chensun please feel free to comment if you need me to change anything else. thanks a lot. :)

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks, @cybernagle !

@google-oss-prow google-oss-prow bot added the lgtm label Feb 9, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit e6ddb0c into kubeflow:master Feb 9, 2024
5 checks passed
roytman pushed a commit to roytman/pipelines that referenced this pull request Feb 14, 2024
kubeflow#9940 (kubeflow#10268)

function getPipelineByName have a version typo:
V1beta1 -> v1beta1

Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
stijntratsaertit pushed a commit to stijntratsaertit/kfp that referenced this pull request Feb 16, 2024
kubeflow#9940 (kubeflow#10268)

function getPipelineByName have a version typo:
V1beta1 -> v1beta1
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 27, 2024
kubeflow#9940 (kubeflow#10268)

function getPipelineByName have a version typo:
V1beta1 -> v1beta1
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 29, 2024
kubeflow#9940 (kubeflow#10268)

function getPipelineByName have a version typo:
V1beta1 -> v1beta1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants