feat(sdk): add local execution skeleton #localexecution #10292
Conversation
|
Skipping CI for Draft Pull Request. |
connor-mccarthy
force-pushed
the
local-execution-state-pattern
branch
from
0e0f3f0
to
0552bae
Compare
|
/assign @chensun |
connor-mccarthy
force-pushed
the
local-execution-state-pattern
branch
from
0552bae
to
94cc3a0
Compare
| if self.state == TaskState.FINAL: | ||
| raise Exception( | ||
| custom_message or | ||
| f"Task configuration methods are not supported for local execution. Got call to '.{method_name}()'." |
There was a problem hiding this comment.
@chensun, I tend to think having an error message that is specific to local-execution is helpful for the user since that's the only case when a task will be FINAL, but please let me know if you prefer we make the error message less specific.
Also, preferring the general Exception to NotImplementedError, which doesn't seem to fit based on its description.
connor-mccarthy
force-pushed
the
local-execution-state-pattern
branch
from
94cc3a0
to
71f36f9
Compare
|
@connor-mccarthy: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| if self.state == TaskState.FINAL: | ||
| raise Exception( | ||
| custom_message or | ||
| f"Task configuration methods are not supported for local execution. Got call to '.{method_name}()'." |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
Description of your changes:
Local execution PR 2.
Adds the skeleton code for invoking local execution (behind a feature flag).
If a component is called outside of a pipeline, it will be executed by
task_dispatcher.run_single_component. ThePipelineTaskhas handling for local execution.Checklist: