Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test loading all component.yaml definitions #1045

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Mar 26, 2019

This ensures that broken definitions are not submitted. (And that the SDK changes do not break existing components.)


This change is Reviewable

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Mar 26, 2019

/approve

@hongye-sun
Copy link
Contributor

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Mar 27, 2019

@IronPan , can you please approve this PR?

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Mar 30, 2019

/approve

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Mar 30, 2019

/approve cancel

@IronPan
Copy link
Member

IronPan commented Apr 2, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 68beebf into kubeflow:master Apr 2, 2019
@Ark-kun Ark-kun deleted the Test-loading-all-component.yaml-definitions branch April 6, 2019 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants