Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kubernetes_platform): Add k8s FieldPath as env to the kubernetes_platform #10485

Merged
merged 1 commit into from Feb 15, 2024

Conversation

Tomcli
Copy link
Member

@Tomcli Tomcli commented Feb 14, 2024

Description of your changes:
Part of #10155

Add new kubernetes_platform spec to set env from the metadata values and also the pod field values. The FieldPath value will always be a string based on the k8s documentation: https://kubernetes.io/docs/tasks/inject-data-application/environment-variable-expose-pod-information/

Checklist:

Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com>
@Tomcli
Copy link
Member Author

Tomcli commented Feb 14, 2024

/assign @connor-mccarthy
/assign @chensun
cc @roytman

Copy link

@Tomcli: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kfp-kubernetes-execution-tests 47a79f4 link false /test kfp-kubernetes-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Feb 15, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit b9ae095 into kubeflow:master Feb 15, 2024
9 of 10 checks passed
@Tomcli Tomcli deleted the fieldpath-env branch February 15, 2024 16:58
KevinGrantLee pushed a commit to KevinGrantLee/pipelines that referenced this pull request Feb 15, 2024
…_platform (kubeflow#10485)

Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com>
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 27, 2024
…_platform (kubeflow#10485)

Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com>
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 29, 2024
…_platform (kubeflow#10485)

Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants