Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): make full version dropdown show on all KFP SDK docs versions #10577

Conversation

connor-mccarthy
Copy link
Member

@connor-mccarthy connor-mccarthy commented Mar 15, 2024

Description of your changes:
Before this change, the reference docs for old versions of the KFP SDK will not shower newer available versions. Going forward, old versions will show newer versions of the reference docs.

I will also apply this to existing release branches to help with discoverability of new versions.

Checklist:

Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: connor-mccarthy <mccarthy.connor.james@gmail.com>
@connor-mccarthy connor-mccarthy force-pushed the make-version-list-visible-on-all-versions branch from 1425c6a to 7fa2f35 Compare March 15, 2024 23:51
@connor-mccarthy connor-mccarthy marked this pull request as ready for review March 15, 2024 23:52
@connor-mccarthy
Copy link
Member Author

/assign @chensun

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Mar 19, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit d3e2de4 into kubeflow:master Mar 19, 2024
9 checks passed
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 27, 2024
…ns (kubeflow#10577)

Signed-off-by: connor-mccarthy <mccarthy.connor.james@gmail.com>
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 29, 2024
…ns (kubeflow#10577)

Signed-off-by: connor-mccarthy <mccarthy.connor.james@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants