Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modified the swagger json files according to the modified proto files. #10591

Merged
merged 1 commit into from Mar 21, 2024

Conversation

amadhusu
Copy link
Contributor

Description of your changes:
Continuation of the modifications made in the PR 10581
This will help resolve issue #10451 . This will help us generate the new API docs with the correction.

Checklist:

Signed-off-by: Achyut Madhusudan <amadhusu@redhat.com>
Copy link

Hi @amadhusu. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Tomcli
Copy link
Member

Tomcli commented Mar 20, 2024

/ok-to-test

@amadhusu
Copy link
Contributor Author

@Tomcli @chensun can I get your reviews here so I can generate the new API docs via the tool?

Copy link
Member

@Tomcli Tomcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tomcli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit cc971c9 into kubeflow:master Mar 21, 2024
6 checks passed
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 27, 2024
…files. (kubeflow#10591)

Signed-off-by: Achyut Madhusudan <amadhusu@redhat.com>
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 29, 2024
…files. (kubeflow#10591)

Signed-off-by: Achyut Madhusudan <amadhusu@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants