fix(backend): Update backend common code and integration tests with updated API Service Params

[gmfrasca]

Description of your changes:
Fixes #10629 , Supercedes #10631

The 2.1.0 release updated the API Generator, which in turn updated the signature/names of most of the *Params APIs. This PR refactors all instances to use the newly generated naming schema

Checklist:

• The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

[google-oss-prow]

Hi @gmfrasca. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Tomcli]

/ok-to-test

[Tomcli]

Thanks @gmfrasca, seems like the integration test is passed but the upgrade test is failing. Feel free to let us know if you are blocked by anything in the ci/cd.

[Tomcli]

/cc @chensun

[gmfrasca]

Update:

So both tests are failing due to an issue with unexpected responses (see example error printout[1]). I tried tracing the error flow and while doing so noticed that the available schemes were reduced from http AND https to simply http (see example change in DefaultSchemes for various *_client.go, such as backend/api/v1beta1/go_http_client/experiment_client/experiment_client.go). These were generated via protobuf so I'm not entirely sure where that is specified but my suspicion is that this may be the root cause of the integration test failures (since they are using live connections/traffic while backend unit tests are not)

[1] errortext:

Failed to list experiments. Raw error from the service: Issue calling the service. Use the '--debug' flag to see the HTTP request/response. Raw error from the client: invalid character 'C' looking for beginning of value

[gmfrasca]

/hold

Tested manually updating the DefaultScheme and Scheme values as I suspected in previous message. Local testing is promising, so pushing a WIP commit to see how CI fares.

If it passes we need to figure out how to make sure API Generation includes the option

[gmfrasca]

alright, looks like all CI is passing as hoped, with just a very minor expected syntax update made. :)

Given that, I did some more digging and found a change in grpc-gateway[1] that makes the schemes spec default to emptyset ([]) rather than ["http", "https"], so perhaps that's the root cause be it grpc-gateway or go-swagger making accommodations because of that change (although with the versions pinned I'm not sure how the behavior managed to change here). So with that said, updating the base .protos to include schemes: ["http", "https"] and running the generator appears to correctly generate the rest of the files.

The following commit will have these changes made, but my testing infra has hibernated for the night so this is a shot in the dark that CI remains passing. Assuming it does, I believe this PR is ready for final review and can be unblocked.

[1] grpc-ecosystem/grpc-gateway@7dddcb1

[rimolive]

@Tomcli @chensun Can you please review?

[Tomcli]

/lgtm

[chensun]

/lgtm
/approve

Thank you, @gmfrasca!

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• backend/OWNERS [chensun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chensun]

/unhold