Passing the annotations and labels to the ContainerOp #1077
Conversation
There was a problem hiding this comment.
Thanks @Ark-kun . The intent with this metadata was definitely not something which we utilize at the backend - but more for frontend systems to have the ability to insert metadata which can be used to describe the component.
The PR now enables the backend to be able to utilize it as well, if needed. Thanks
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Currently the annotations and labels are not passed from component to the ContainerOp. This PR fixes that. Fixes kubeflow#1013
Ark-kun
force-pushed
the
Passing-the-annotations-and-labels-to-the-ContainerOp
branch
from
beb31f5
to
addec1e
Compare
|
/lgtm |
Ark-kun
deleted the
Passing-the-annotations-and-labels-to-the-ContainerOp
branch
…task param (kubeflow#1077) * fix underscore param by checking pipeline param instead of task param * update test cases
Currently the annotations and labels are not passed from component to the
ContainerOp. This PR fixes that.Fixes #1013
This change is