Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade node to v18 #10794

Merged
merged 1 commit into from
May 9, 2024

Conversation

HumairAK
Copy link
Contributor

@HumairAK HumairAK commented May 6, 2024

Description of your changes:
Resolves: #10770
Furthers: #10777

Note while node 18 is still in maintenance, this is not the latest 18.x release, which is 18.20.2 as of this writing. I was encountering issues with 18.19 and 18.20, so I settled for 18.18 to resolve the current build issues. But we update to the latest as a follow up.

@craco/craco also needed a minor version bump, and package-lock.json was updated via npm i --package-lock-only, with the following env:

{
  npm: '9.8.1',
  node: '18.18.2',
}

I'm not well versed in frontend so if this is not the right way, let me know and I can update it.

Checklist:

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Copy link

google-oss-prow bot commented May 6, 2024

@HumairAK: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipeline-e2e-test 32c4828 link false /test kubeflow-pipeline-e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@HumairAK
Copy link
Contributor Author

HumairAK commented May 7, 2024

/test kubeflow-pipeline-frontend-test

@HumairAK
Copy link
Contributor Author

HumairAK commented May 7, 2024

cc @chensun / @zijianjoy

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit d91a70a into kubeflow:master May 9, 2024
3 of 4 checks passed
@orfeas-k
Copy link

Are there any plans of backporting this to a specific release/version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[frontend] incompatible error while building frontend image
3 participants