Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Migrate KFP SDK YAPF test to a GHA Workflow #10961

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

DharmitD
Copy link
Contributor

@DharmitD DharmitD commented Jun 26, 2024

Description of your changes:
Resolves #10925

Converts the KFP SDK YAPF test to a GH Action Workflow.

Here's a working GH Action run on my fork: https://github.com/DharmitD/data-science-pipelines-argo/actions/runs/9672832818

PR to remove the KFP SDK YAPF test from prow config: GoogleCloudPlatform/oss-test-infra#2310

Checklist:

Signed-off-by: ddalvi <ddalvi@redhat.com>
@DharmitD
Copy link
Contributor Author

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@DharmitD
Copy link
Contributor Author

@chensun could you please take a look?
Here's the PR to remove the KFP SDK YAPF test from prow config: GoogleCloudPlatform/oss-test-infra#2310
thank you!

@hbelmiro
Copy link
Contributor

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbelmiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit d499172 into kubeflow:master Jun 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Prow P0 SDK tests to GH Actions
2 participants