Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug in parameterized sample. #13

Merged
merged 1 commit into from Jun 9, 2018
Merged

Fixing bug in parameterized sample. #13

merged 1 commit into from Jun 9, 2018

Conversation

vicaire
Copy link
Contributor

@vicaire vicaire commented Jun 9, 2018

This change is Reviewable

@k8s-ci-robot k8s-ci-robot requested a review from jlewi June 9, 2018 03:58
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jlewi

Assign the PR to them by writing /assign @jlewi in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vicaire vicaire merged commit 157ccbd into master Jun 9, 2018
@IronPan IronPan deleted the vicaire/samples branch June 4, 2019 07:30
HumairAK added a commit to HumairAK/data-science-pipelines that referenced this pull request Feb 2, 2024
UPSTREAM: <carry>: remove direct k8s pkg import.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants