Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose namespace config for persistent agent #1308

Merged
merged 1 commit into from May 10, 2019
Merged

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented May 10, 2019

this config allow specifying what namespace the persistent agent listen to


This change is Reviewable

this config allow specifying what namespace the persistent agent listen to
@IronPan
Copy link
Member Author

IronPan commented May 10, 2019

/assign @ywskycn

@ywskycn
Copy link
Member

ywskycn commented May 10, 2019

/lgtm

@IronPan
Copy link
Member Author

IronPan commented May 10, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 27bdbda into master May 10, 2019
@IronPan IronPan deleted the IronPan-patch-6 branch May 30, 2019 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants