Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Components - Added component properties to the task factory function #1771

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Aug 8, 2019

Problem: When the user loads component using the load_component function, the object they get back is a task factory function. Since it's a notmal function object, the user cannot inspect any of the attributes of the component they just loaded (they can only see the name, description and input names). For example, the user cannot see the list of component outputs, the annotations etc.

This change fixes the issue by adding the original component properties to the function object.

Example usage:

train_op = load_component_from_url(...)
print(train_op.outputs)

This change is Reviewable

…ction

Problem: When the user loads component using the load_component function, the object they get back is a task factory function. Since it's a normal function object, the user cannot inspect any of the attributes of the component they just loaded (they can only see the name, description and input names). For example, the user cannot see the list of component outputs, the annotations etc.

This change fixes the issue by adding the original component properties to the function object.

Example usage:

```python
train_op = load_component_from_url(...)
print(train_op.outputs)
```
@Ark-kun Ark-kun force-pushed the SDK---Components---Added-component-properties-to-the-task-factory-function branch from 4279a6b to d3be07f Compare August 29, 2019 23:46
@ajchili
Copy link
Member

ajchili commented Aug 29, 2019

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 30, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f5b2f24 into kubeflow:master Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants