Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for dependencies in the component image building #219

Merged
merged 13 commits into from Nov 17, 2018
Merged

add support for dependencies in the component image building #219

merged 13 commits into from Nov 17, 2018

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Nov 12, 2018 •
edited by jlewi

This change is Reviewable

@gaoning777 gaoning777 self-assigned this Nov 12, 2018
@coveralls
Copy link

coveralls commented Nov 12, 2018 •
edited

Pull Request Test Coverage Report for Build 312

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 67.531%
Files with Coverage Reduction New Missed Lines %
src/components/Router.tsx 13 49.18%
Totals Coverage Status
Change from base Build 251: 0.02%
Covered Lines: 1542
Relevant Lines: 2193
💛 - Coveralls

@gaoning777
Copy link
Contributor Author

/retest

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 16, 2018

Some of my reviews got deleted due code changes, so here is recap:
There is a bug in the code and the tests fail to catch it. I'm calling for better testing such that the bug is caught. This is not about fixing the particular bug, but more about writing better tests.

@gaoning777
Copy link
Contributor Author

Good suggestion about good unit test coverage.
But please point out the bug you found.

@gaoning777
Copy link
Contributor Author

Synced offline. There is a bug with the DependencyHelper.
Thanks for catching this.

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 17, 2018

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 17, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7d811bf into master Nov 17, 2018
@gaoning777
Copy link
Contributor Author

/approve

@gaoning777 gaoning777 deleted the ngao/component-image-requirement branch November 19, 2018 17:59
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@richardsliu @k8s-ci-robot
Allow checkout.sh to process branch name (kubeflow#219)
794c329
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ark-kun Ark-kun Ark-kun left review comments

@qimingj qimingj Awaiting requested review from qimingj

Assignees

@Ark-kun Ark-kun

@gaoning777 gaoning777

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gaoning777 @coveralls @Ark-kun @k8s-ci-robot