Samples/Notebooks - Added basic component sharing notebooks #238
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -0,0 +1,155 @@ | |||
| { | |||
There was a problem hiding this comment.
It seems neither notebook is big --- merge them? How to produce and how to load are very related.
| "outputs": [], | ||
| "source": [ | ||
| "#Install the SDK\n", | ||
| "!pip3 install https://storage.googleapis.com/ml-pipeline/release/0.1.3-rc.3/kfp.tar.gz --upgrade\n" |
There was a problem hiding this comment.
0.1.3-rc3 --> 0.1.6. (sorry it has been a while after this change is out for review).
| "\n", | ||
| "There are several requirements for the function:\n", | ||
| "* The function should be stand-alone. It should not use any code declared outside of the function definition. Any imports should be added inside the main function. Any helper functions should also be defined inside the main function.\n", | ||
| "* The function can only import packages that are available in the base image. If you need to import a package that's not available you can try to find a container image that already includes the required packages. (As a workaround you can use the module subprocess to run pip install for the required package.)\n", |
There was a problem hiding this comment.
Maybe add a link to the sample notebook which demonstrates how to build a container inside cluster? Or even include some code snippets?
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "Simple function that just add two numbers:" |
| " description='A toy pipeline that performs arithmetic calculations.'\n", | ||
| ")\n", | ||
| "def calc_pipeline(\n", | ||
| " a=dsl.PipelineParam('a'),\n", |
There was a problem hiding this comment.
It doesn't have to be "dsl.PipelineParam" type now.
|
@Ark-kun, do you still need this one? Should we close? |
I think so. We almost released this before GA, but then decided to release it right after GA. I think we'll merge it next week. |
|
What is the status of this PR? Should we close it or it's good for review? |
|
@Ark-kun: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
lifecycle/stale
|
This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it. |
This change is