Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Save pod desc text and stackdriver link as artifacts #2791

Merged

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Jan 3, 2020

Existing problem

Unhealthy pod description is usually too long and very distracting. e.g. https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/kubeflow_pipelines/2786/kubeflow-pipeline-sample-test/1211813796222341120#1:build-log.txt%3A7345 the description section is too long that it's hard to find which steps passed.
But they are usually not even enough, we also need pod logs to identify the issue.

Proposed solution

Save information related to each pod in a text file in artifacts.
Each file contains:

  1. pod yaml
  2. pod description
  3. pod logs link

This change is Reviewable

@Bobgy
Copy link
Contributor Author

Bobgy commented Jan 3, 2020

Artifacts are not saved, fixing artifact location according to https://github.com/kubernetes/test-infra/blob/master/prow/jobs.md#job-environment-variables

@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Jan 3, 2020
@Ark-kun
Copy link
Contributor

Ark-kun commented Jan 3, 2020

/lgtm

@Bobgy
Copy link
Contributor Author

Bobgy commented Jan 4, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor Author

Bobgy commented Jan 5, 2020

/test kubeflow-pipeline-sample-test

@k8s-ci-robot k8s-ci-robot merged commit 8147fe5 into kubeflow:master Jan 5, 2020
@Bobgy Bobgy deleted the testing_save_pod_logs_as_artifact branch January 6, 2020 02:53
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
…low#2791)

* Save pod desc text and stackdriver link as artifacts

* Fix artifact location

* Restructure artifact

* Also log pod yaml
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants