Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Update node to 12 #2830

Merged
merged 1 commit into from Jan 13, 2020
Merged

[UI] Update node to 12 #2830

merged 1 commit into from Jan 13, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Jan 13, 2020

Fixes #2386

With node server unit tests in place, let's update this.


This change is Reviewable

@Bobgy
Copy link
Contributor Author

Bobgy commented Jan 13, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy Bobgy added the lgtm label Jan 13, 2020
@Bobgy Bobgy mentioned this pull request Jan 13, 2020
2 tasks
@k8s-ci-robot k8s-ci-robot merged commit 6d8cab0 into kubeflow:master Jan 13, 2020
@Bobgy Bobgy deleted the fe_upgrade_node branch January 13, 2020 06:29
rui5i pushed a commit to rui5i/pipelines that referenced this pull request Jan 16, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Fix raw deployment status.address.url displays wrong url

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* resolve comments

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend] upgrade node to 12 LTS
2 participants