Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend - Annotate Workflow with the run name #2902

Merged
merged 1 commit into from Jan 30, 2020
Merged

Backend - Annotate Workflow with the run name #2902

merged 1 commit into from Jan 30, 2020

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jan 23, 2020 •
edited by jlewi

This change is Reviewable

@IronPan
Copy link
Member

IronPan commented Jan 28, 2020

Is there any reason metadata writer needs to know the run name instead of run id which uniquely identifies the run?

@IronPan
Copy link
Member

IronPan commented Jan 28, 2020

/lgtm

@IronPan
Copy link
Member

IronPan commented Jan 28, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 30, 2020

/retest

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 30, 2020

Is there any reason metadata writer needs to know the run name instead of run id which uniquely identifies the run?

This simplifies information flow to be one-way:

SDK -> Backend -> Argo -> Kubernetes -> Metadata Writer -> MLMD

This way the Metadata Writer does not need to talk back to the Backend.

Alternatively, Backend could pre-create the MLMD Context for the run and stamp the workflow with Context ID and Run ID.

@k8s-ci-robot k8s-ci-robot merged commit dd583ab into kubeflow:master Jan 30, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@Ark-kun @Jeffwan
Backend - Annotate Workflow with the run name (kubeflow#2902)
616788e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan Awaiting requested review from IronPan

@rmgogogo rmgogogo Awaiting requested review from rmgogogo

@jingzhang36 jingzhang36 Awaiting requested review from jingzhang36

@neuromage neuromage Awaiting requested review from neuromage

Assignees

@IronPan IronPan

@rmgogogo rmgogogo

@dushyanthsc dushyanthsc

Labels
approved area/backend lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ark-kun @IronPan @k8s-ci-robot @rmgogogo @dushyanthsc