Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MKP] Add initializaion action for MKP deployer #2932

Merged
merged 12 commits into from Jan 30, 2020

Conversation

numerology
Copy link

@numerology numerology commented Jan 29, 2020

in order to automatically create a bucket.

It also populate a configmap named 'gcp-default-config' for later use.

Pending manual tests.
Verified auto bucket creation and configmap creation is working.


This change is Reviewable

@numerology
Copy link
Author

/hold testing

@numerology numerology changed the title [MKP][WIP] Add initializaion action for MKP deployer [MKP] Add initializaion action for MKP deployer Jan 29, 2020
@numerology
Copy link
Author

/assign @rmgogogo
/assign @IronPan
/cc @SinaChavoshi

@numerology
Copy link
Author

/hold cancel

@numerology
Copy link
Author

@rmgogogo Can you confirm how to access the EnableFullScope flag? I think it'll be better if we can direct use that flag instead of infer from different error msgs...

Copy link
Member

@IronPan IronPan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@numerology
Copy link
Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit d9fb85d into kubeflow:master Jan 30, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* update docker

* add gcloud sdk

* add gcs creation and configmap

* fix lint

* update docker

* rename/move old deploy.sh

* add permission

* typo

* fix random id

* namespace typo

* add project id

* fix typo
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants