Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Components - create_graph_component_from_pipeline_func now returns a function #2971

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Feb 3, 2020

The return behavior is now consistent with create_component_from_func.


This change is Reviewable

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Feb 4, 2020

/retest

2 similar comments
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Feb 4, 2020

/retest

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Feb 5, 2020

/retest

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Feb 6, 2020

@numerology The tests are passing.

@numerology
Copy link

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Feb 6, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Feb 6, 2020

/retest

1 similar comment
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Feb 9, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 9b8e14c into kubeflow:master Feb 9, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants