Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduce proxy type from the presence of client_id #3003

Merged
merged 4 commits into from
Feb 10, 2020
Merged

Deduce proxy type from the presence of client_id #3003

merged 4 commits into from
Feb 10, 2020

Conversation

chensun
Copy link
Member

@chensun chensun commented Feb 6, 2020 •
edited by jlewi
Loading

  • Use the presence of client_id to deduce whether it's Identity-Aware Proxy or Inverse Proxy.
  • Remove the logic of detecting proxy type based on the endpoint URL.

Fixes #2244 @daikeshi

This change is Reviewable

@chensun chensun mentioned this pull request Feb 6, 2020
Closed
@chensun
Copy link
Member Author

chensun commented Feb 6, 2020

/assign @IronPan

@chensun
Copy link
Member Author

chensun commented Feb 6, 2020

/retest

2 similar comments
@chensun
Copy link
Member Author

chensun commented Feb 6, 2020

/retest

@chensun
Copy link
Member Author

chensun commented Feb 6, 2020

/retest

@Ark-kun
Copy link
Contributor

Ark-kun commented Feb 6, 2020

/lgtm

@Ark-kun Ark-kun requested a review from IronPan February 6, 2020 23:14
@numerology
Copy link

/lgtm
Do you mind approving? @Ark-kun

@chensun
Copy link
Member Author

chensun commented Feb 7, 2020

/retest

2 similar comments
@chensun
Copy link
Member Author

chensun commented Feb 7, 2020

/retest

@chensun
Copy link
Member Author

chensun commented Feb 7, 2020

/retest

@numerology
Copy link

/approve
/retest

@chensun
Copy link
Member Author

chensun commented Feb 7, 2020

/retest

2 similar comments
@chensun
Copy link
Member Author

chensun commented Feb 7, 2020

/retest

@chensun
Copy link
Member Author

chensun commented Feb 7, 2020

/retest

@numerology
Copy link

run-sample-tests-loop(7:execution_order)�[0m: subprocess.CalledProcessError: Command '['gcloud', 'auth', 'print-access-token']' returned non-zero exit status 1

Does not seem to be a flakiness :(

@chensun
Copy link
Member Author

chensun commented Feb 8, 2020

run-sample-tests-loop(7:execution_order)�[0m: subprocess.CalledProcessError: Command '['gcloud', 'auth', 'print-access-token']' returned non-zero exit status 1

Does not seem to be a flakiness :(

Found why it's failing. The format of this endpoint string previously wouldn't go into the get_gcp_access_token path.

I'm going to make get_gcp_access_token handle error gracefully.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 8, 2020
@chensun
Copy link
Member Author

chensun commented Feb 8, 2020

/retest

2 similar comments
@chensun
Copy link
Member Author

chensun commented Feb 8, 2020

/retest

@chensun
Copy link
Member Author

chensun commented Feb 9, 2020

/retest

@chensun
Copy link
Member Author

chensun commented Feb 10, 2020

@numerology can you please take a second look?

@numerology
Copy link

/lgtm
/approve

Thanks @chensun

@IronPan
Copy link
Member

IronPan commented Feb 10, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan, numerology

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 587292f into kubeflow:master Feb 10, 2020
@chensun chensun deleted the proxy branch February 10, 2020 22:45
@Bobgy Bobgy mentioned this pull request Mar 10, 2020
Closed
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@chensun @Jeffwan
Deduce proxy type from the presence of client_id (kubeflow#3003)
9084556 
* Deduce proxy type from presence of client_id

* handle error in get_gcp_access_token()

* restore the logic to detect inverse proxy host
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

@gaoning777 gaoning777 Awaiting requested review from gaoning777

@IronPan IronPan Awaiting requested review from IronPan

Assignees

@Ark-kun Ark-kun

@IronPan IronPan

@numerology numerology

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IAP host shouldn't be restricted to a cloud endpoint url
5 participants
@chensun @Ark-kun @numerology @IronPan @k8s-ci-robot