Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement filtering in ListPipelines #3040

Merged
merged 1 commit into from Feb 12, 2020
Merged

Conversation

jiezhang
Copy link

@jiezhang jiezhang commented Feb 11, 2020

This PR fixes issue #2945 by adding filter to the ListPipelines API.

Because ListPipelines joins table pipelines and pipeline_versions, and they both have a column name, we need to fully qualify the column in NewWithKeyMap to avoid "ambiguous column name" error.


This change is Reviewable

@googlebot
Copy link
Collaborator

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@jiezhang
Copy link
Author

/retest

@jiezhang
Copy link
Author

/test kubeflow-pipeline-sample-test

1 similar comment
@jiezhang
Copy link
Author

/test kubeflow-pipeline-sample-test

@jiezhang
Copy link
Author

/assign @jingzhang36
/assign @IronPan

@IronPan
Copy link
Member

IronPan commented Feb 12, 2020

/lgtm
/approve

1 similar comment
@IronPan
Copy link
Member

IronPan commented Feb 12, 2020

/lgtm
/approve

@IronPan
Copy link
Member

IronPan commented Feb 12, 2020

/test kubeflow-pipeline-sample-test

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c51c96a into kubeflow:master Feb 12, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Feb 12, 2020

Fixes #2945

Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Bump scikit-learn version to 1.3.0

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Update test models

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Downgrade ray serve to 2.4

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants