Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PipelineSelector, RecurringRunsManager, and 404Page tests #319

Merged
merged 7 commits into from
Nov 26, 2018

Conversation

yebrahim
Copy link
Contributor

@yebrahim yebrahim commented Nov 20, 2018

No functional changes, only some cleanup.


This change is Reviewable

Copy link
Contributor

@rileyjbauer rileyjbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

frontend/src/pages/PipelineSelector.test.tsx Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rileyjbauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rileyjbauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yebrahim
Copy link
Contributor Author

/test presubmit-e2e-test

@rileyjbauer
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit b8e185d into master Nov 26, 2018
@yebrahim yebrahim deleted the yebrahim/page-tests branch November 28, 2018 00:01
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* clean up unused bindings in iam

* fix

* request body change

* address comment

* delete unused members for each binding

* fix pylint

* add unit test for trim bindings logic
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants