Add Gopkg dependency for kubernetes code-generator. #371
Conversation
vendor/OWNERS
Outdated
| @@ -1,10 +0,0 @@ | |||
| approvers: | |||
There was a problem hiding this comment.
is this change intentional? if not is there any way to persist this file?
There was a problem hiding this comment.
Running dep ensure will delete that file, since all contents under vendor are assumed to be generated. I'm not sure how to keep that file in. Also I'm not sure if there's a benefit of having an OWNERS file in the vendor directory is, since changes under this directory should be a side effect of code, rather than a code change itself. What do you think?
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vicaire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test build-image |
neuromage
force-pushed
the
neuromage/crd-dependencies
branch
from
24ea6ff
to
8988617
Compare
The code generator should not be run from HEAD, as it will generate code that diverges from the pinned version of client-go, and also any previously generated CRD controller clients. This change pins both code generator and client-go to the specified kubernetes release, and ensures the update-codegen.sh script uses the code-generator specified in the vendor directory rather than HEAD. This ensures the build is always reproducible.
neuromage
force-pushed
the
neuromage/crd-dependencies
branch
from
8988617
to
3267267
Compare
|
/lgtm |
|
/retest |
1 similar comment
|
/retest |
|
/test presubmit-e2e-test |
The code generator should not be run from HEAD, as it will generate code
that diverges from the pinned version of client-go, and also any
previously generated CRD controller clients.
This change pins both code generator and client-go to the specified
kubernetes release, and ensures the update-codegen.sh script uses the
code-generator specified in the vendor directory rather than HEAD. This
ensures the build is always reproducible.
Note: I made changes to Gopkg.toml and the update-codegen.sh script. The changes in vendor/ is the result of running
dep ensure.This change is