Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Amy and Lak's Blogs Link to README #375

Merged
merged 3 commits into from
Nov 27, 2018
Merged

Add Amy and Lak's Blogs Link to README #375

merged 3 commits into from
Nov 27, 2018

Conversation

qimingj
Copy link
Contributor

@qimingj qimingj commented Nov 26, 2018

This change is Reviewable

README.md Outdated
@@ -17,6 +17,11 @@ The Kubeflow pipelines service has the following goals:

Get started with your first pipeline and read further information in the [documentation](https://github.com/kubeflow/pipelines/wiki).

## Blogs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Call this "Blog posts about Kubeflow Pipelines" or something similar?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "Blogs" is clear enough but let's see what @sarahmaddox says.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd go with "Blog posts". If we say just "Blogs", it implies we're recommending entire blog sites that are about Kubeflow. I don't think we need to add "about Kubeflow Pipelines" as people can infer that from the context.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. Thanks Sarah.

Copy link
Contributor

@yebrahim yebrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise,
/lgtm

@vicaire
Copy link
Contributor

vicaire commented Nov 26, 2018

/lgtm

Copy link
Contributor

@sarahmaddox sarahmaddox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@qimingj
Copy link
Contributor Author

qimingj commented Nov 27, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qimingj, sarahmaddox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b61efd0 into master Nov 27, 2018
@IronPan IronPan deleted the readme2 branch June 28, 2019 18:47
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants