Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK/Components - Removed outputs from task factory function signature #388

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Nov 27, 2018

This realizes the outputs handling vision and solves problems with input and output name clashes.


This change is Reviewable

@Ark-kun Ark-kun requested a review from qimingj November 27, 2018 06:54
@Ark-kun Ark-kun force-pushed the avolkov/SDK/Components---Stopped-allowing-the-user-specify-output-paths-when-calling-task-factory branch from ee3f2aa to f82ba29 Compare December 1, 2018 05:43
@qimingj
Copy link
Contributor

qimingj commented Dec 2, 2018

/lgtm

This realizes the outputs handling roadmap and solves problems with input and output name clashes.
@Ark-kun Ark-kun force-pushed the avolkov/SDK/Components---Stopped-allowing-the-user-specify-output-paths-when-calling-task-factory branch from f82ba29 to dae7b13 Compare December 3, 2018 19:48
@qimingj
Copy link
Contributor

qimingj commented Dec 3, 2018

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 3, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 96ec194 into master Dec 3, 2018
@Ark-kun Ark-kun deleted the avolkov/SDK/Components---Stopped-allowing-the-user-specify-output-paths-when-calling-task-factory branch January 15, 2019 22:09
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* fix the cleanup-ci jsonnet

* print http reponse

* update scripts

* lint
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* use endpoint status map

* patch tests

* update codeget

* make the map a ptr

* fix TestKFServiceWithOnlyPredictor

* fix canary predictor test

* fix TestKFServiceWithOnlyPredictor with sad sleep

* update printer columns

* update codegen and move url up
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
…flow#403)

* Update metrics reporter unit tests

* Update persistence worker unit tests

* Update workflow saver unit tests

* Fix spelling typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants