Samples/Notebooks - Partially restored the lightweight components sample #555
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ark-kun
force-pushed
the
Notebooks---Partially-restoring-the-Lighweight-components-sample
branch
from
6b7fdb6
to
06513c9
Compare
| " from pathlib import Path\n", | ||
| "\n", | ||
| " #FIX: Metadata and metrics should be output like all other outputs\n", | ||
| " ui_metadata_output_path='/mlpipeline-ui-metadata.json'\n", |
There was a problem hiding this comment.
How do you make it work when user run the notebook in jupyter when the path is under root?
|
Are you planning to close this issue? since you did not try to resolve hongye's concern, should we close it? |
|
@Ark-kun: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
lifecycle/stale
|
This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it. |
* update go-license-tool README * fix typo * address comments * fix typos
* Merge KFP changes between 1.5.0-rc.2 and 1.5.0 Resolves kubeflow#554 * Resolve backend and manifest conflicts * Resolve frontend conflicts
Removed the unneeded TF dependency.
Made the metrics and metadata outputs a bit less ugly. (Needs to be properly fixed in future)
This change is