-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk compiler):Fix v2 compile for exit handler Fixes #5854 #5899
fix(sdk compiler):Fix v2 compile for exit handler Fixes #5854 #5899
Conversation
Hi @TrsNium. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test Thank you @TrsNium for the fix! I actually plan to fix this today, but you beat me :) Can you please also update the test sample: pipelines/sdk/python/kfp/v2/compiler_cli_tests/test_data/pipeline_with_exit_handler.py Lines 36 to 42 in 1983037
You can change the
Once done, you can update the golden json by executing the file: |
@chensun |
09c6c11
to
67fe5cd
Compare
67fe5cd
to
bb8f5d6
Compare
Thanks again for your contribution. This "punch the hole" thing is a tricky one. Very impressive that you were able to figure this out by yourself. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
If
exit_handler
is used, an error will occur at compile time because inputs are not set for tasks in that group(#5854)So, set input as well as
condition
subgroup.Checklist: