feat(sdk.v2): Support container environment variable in v2. #6515
Conversation
| _PipelineContainerSpec.EnvVar(name=name, value=value) | ||
| for name, value in self.env_dict.items() | ||
| ]) | ||
| return self |
There was a problem hiding this comment.
Maybe not for this PR, but I realized a lot of setting/adding functions return the Container. Wondering whether returning the container is needed, since the user setting the requirements already has the container?
There was a problem hiding this comment.
Yes, the reason for returning container is to allow chained setting, for example, task.set_cpu_limi(...).set_env_variable(...).set_caching_option(...).
Without return self, the above setting has to be split into multi-lines:
task.set_cpu_limi(...)
task.set_env_variable(...)
task.set_caching_option(...)
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
In v1, the
add_env_variable()method takes an input of typekubernetes.client.models.V1EnvVar, which does not fit for Vertex Pipelines. So we add a new methodset_env_variable()for v2.The new method accepts a pair of
nameandvaluefrom constant values, but not fromPipelineParam. The same limitation also exists in v1add_env_variable().Checklist: