chore(sdk): relax click version to click>=7.1.2,<9. Fixes #6651 #6691
Conversation
|
Hi @juliusvonkohout. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
juliusvonkohout
changed the title
| @@ -43,7 +43,7 @@ | |||
| 'kfp-server-api>=1.1.2,<2.0.0', | |||
| 'jsonschema>=3.0.1,<4', | |||
| 'tabulate>=0.8.6,<1', | |||
| 'click>=7.1.1,<8', | |||
| 'click>=7.1.2,<9', | |||
There was a problem hiding this comment.
Since this is a major version bump, have we checked if there was any breaking change from 7 to 8? I'm afraid we don't have test coverage around the SDK CLI, so you probably have to read their changelog and check our code usage on it.
There was a problem hiding this comment.
Well i was able to compile all my pipelines and connect to the apiserver and run my pipelines
There was a problem hiding this comment.
There was a problem hiding this comment.
@chensun is there something specific that i should test?
There was a problem hiding this comment.
click is only relevant to the CLI part. I did a grep search, it looks like we only used the basics, including:
click.group
click.Path
click.confirm
click.option
click.argument
click.pass_context
click.echo
and I had a quick scan of the changelog, it seems we should be fine.
| @@ -43,7 +43,7 @@ | |||
| 'kfp-server-api>=1.1.2,<2.0.0', | |||
| 'jsonschema>=3.0.1,<4', | |||
| 'tabulate>=0.8.6,<1', | |||
| 'click>=7.1.1,<8', | |||
| 'click>=7.1.2,<9', | |||
There was a problem hiding this comment.
click is only relevant to the CLI part. I did a grep search, it looks like we only used the basics, including:
click.group
click.Path
click.confirm
click.option
click.argument
click.pass_context
click.echo
and I had a quick scan of the changelog, it seems we should be fine.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
Fixes #6651
extends #6683
@chensun
Checklist: