Add gpu pool to test deployment and enable gpu in sample test #696
Conversation
|
/test kubeflow-pipeline-e2e-test |
2 similar comments
|
/test kubeflow-pipeline-e2e-test |
|
/test kubeflow-pipeline-e2e-test |
hongye-sun
changed the title
|
@gaoning777, the PR is ready, PTAL. |
| @@ -152,6 +152,7 @@ if [ "$TEST_NAME" == 'tf-training' ]; then | |||
| sed -i -e "s|gcr.io/ml-pipeline/ml-pipeline-dataflow-tf-predict:\([a-zA-Z0-9_.-]\)\+|${DATAFLOW_PREDICT_IMAGE}|g" kubeflow-training-classification.py | |||
| sed -i -e "s|gcr.io/ml-pipeline/ml-pipeline-local-confusion-matrix:\([a-zA-Z0-9_.-]\)\+|${LOCAL_CONFUSIONMATRIX_IMAGE}|g" kubeflow-training-classification.py | |||
| fi | |||
| sed -i -e "s|use_gpu\s*=\s*False|use_gpu = True|g" kubeflow-training-classification.py | |||
There was a problem hiding this comment.
That seems a bit hacky. Could we use proper parameter passing instead of using sed on a Python file?
There was a problem hiding this comment.
We did sed replace all over the places in the test script. There is currently a limitation that user cannot pass gpu setting as pipeline parameter as gpu must be set before the dsl compile time. That's why we cannot use parameter to control this test.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vicaire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vicaire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test kubeflow-pipeline-build-image |
…kubeflow#696)" This reverts commit 72a7de9.
…ple test (kubeflow#696)"" This reverts commit 4c2c52b.
* Fix periodic runs of tekton workflows. * Periodic runs aren't associated with a repository/commit; so we shouldn't try to substitute into the pipelineruns. * Add exception handling so we keep going if a workflow has an exception. * Fix: kubeflow#696 * Fix some whitespace in apps-cd/README.md
* fix e2e test case * fix e2e test case
I temporarily disable the clean up code for debug purpose. Will update the PR once the test passed.
This change is