Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Splitting logsDetails into lines based on CR and LF. Fixes #9593 #9594

Merged

Conversation

axel7083
Copy link
Contributor

@axel7083 axel7083 commented Jun 8, 2023

Description of your changes:

Fixing #9593

Replacing .split('\n') with .split(/[\r\n]+/) to ensure lines are properly split.

Tests:

After fixing the split argument:
image

@google-oss-prow
Copy link

Hi @axel7083. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@axel7083 axel7083 marked this pull request as ready for review June 8, 2023 12:13
@connor-mccarthy
Copy link
Member

/assign @jlyaoyuli

@zijianjoy
Copy link
Collaborator

/lgtm
/approve

Thank you for the contribution!

@google-oss-prow google-oss-prow bot added the lgtm label Jun 22, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chensun
Copy link
Member

chensun commented Jun 22, 2023

/ok-to-test

@zijianjoy
Copy link
Collaborator

/ok-to-test

@google-oss-prow google-oss-prow bot merged commit 536d93a into kubeflow:master Jun 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants