New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm chart does not export container port for webhook when enabled #1962

Closed

zevisert opened this issue Apr 9, 2024 · 1 comment · Fixed by #1961

Contributor

zevisert commented Apr 9, 2024 •

edited

From the deployment template for the helm chart you can see that there is no exposure of the webhook port under any scenario.

spark-operator/charts/spark-operator-chart/templates/deployment.yaml

Lines 49 to 53 in 252eddd

    
           {{- if .Values.metrics.enable }} 
        
           ports: 
        
             - name: metrics 
        
               containerPort: {{ .Values.metrics.port }} 
        
           {{ end }}

The kustomize manifests include a patch to expose both the metrics and webhook ports from the pod, but this seems to be missing from the helm chart.

Contributor Author

zevisert commented Apr 9, 2024

I've already created #1961 to fix this

zevisert mentioned this issue

fix: add containerPort declaration for webhook in helm chart #1961

Merged

google-oss-prow bot closed this as completed in #1961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment